-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 204 No Content response #4834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7562 ↗︎Details:
Review all test suite changes for PR #4834 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4834 +/- ##
==========================================
+ Coverage 86.77% 86.78% +0.01%
==========================================
Files 346 346
Lines 20910 20913 +3
Branches 2732 2733 +1
==========================================
+ Hits 18145 18150 +5
+ Misses 2289 2288 -1
+ Partials 476 475 -1 ☔ View full report in Codecov by Sentry. |
SteveDMurphy
approved these changes
Apr 26, 2024
Confirmed and tested live tonight as well! |
9 tasks
Kelsey-Ethyca
added a commit
that referenced
this pull request
May 3, 2024
Co-authored-by: Kelsey Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Allows a SaaS integration request to process HTTP 204 No Content without erroring trying to unwrap the response.
Pre-Merge Checklist
CHANGELOG.md