Added FidesUpdating event #4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
guncha
commented
Apr 19, 2024
Passing run #7360 ↗︎
Details:
Review all test suite changes for PR #4816 ↗︎ |
||||||||||||||||||||
NevilleS
approved these changes
Apr 21, 2024
Comment on lines
+2896
to
+2904
| // Both FidesUpdating & FidesUpdated should include the fides_string | ||
| cy.get("@FidesUpdating") | ||
| .should("have.been.calledOnce") | ||
| .its("lastCall.args.0.detail.fides_string") | ||
| .then((fidesString) => { | ||
| const parts = fidesString.split(","); | ||
| expect(parts.length).to.eql(2); | ||
| expect(parts[1]).to.eql(acceptAllAcString); | ||
| }); |
There was a problem hiding this comment.
I added this test to be sure 👍
Comment on lines
+1668
to
+1676
| cy.get("@FidesUpdating") | ||
| // Updating event, when the user rejects all | ||
| .should("have.been.calledOnce") | ||
| .its("firstCall.args.0.detail.consent") | ||
| .should("deep.equal", { | ||
| [PRIVACY_NOTICE_KEY_1]: false, | ||
| [PRIVACY_NOTICE_KEY_2]: true, | ||
| [PRIVACY_NOTICE_KEY_3]: false, | ||
| }); |
There was a problem hiding this comment.
I updated this test (and others) to confirm this event does what we expect
Comment on lines
+1744
to
+1748
| // Toggle the notice, but don't save yet | ||
| cy.getByTestId("toggle-Advertising").click(); | ||
| cy.get("@FidesUIChanged").should("have.been.calledOnce"); | ||
| cy.get("@FidesUpdating").should("not.have.been.called"); | ||
| cy.get("@FidesUpdated").should("not.have.been.called"); |
There was a problem hiding this comment.
Unrelated to this change, but I made this test a bit better.
guncha
commented
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1965
Description Of Changes
Adds a new
FidesUpdatingeven that fires (almost) immediately after the user has updated their consent. This allows page code to react to the change sooner thanFidesUpdatedas that will potentially make a network request to save the preferences before firing.Pre-Merge Checklist
CHANGELOG.md