Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly hide privacy policy link unless both label & URL are set #4801

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Apr 16, 2024

Description Of Changes

This was a really small miss on my part - when I localized the PrivacyPolicyLink component I added this check (and even commented on why it's there!) but the logic was totally wrong 😆

Code Changes

  • Fix PrivacyPolicyLink to only render if both label & URL are provided

Steps to Confirm

  • Configure an experience with only the Privacy Policy Label set (but not URL!) and check that link is not shown

Pre-Merge Checklist

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 8:46pm

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

cypress bot commented Apr 16, 2024

Passing run #7280 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7482714 into a9d3ea9...
Project: fides Commit: 167dc618fe ℹ️
Status: Passed Duration: 00:34 💡
Started: Apr 16, 2024 8:58 PM Ended: Apr 16, 2024 8:58 PM

Review all test suite changes for PR #4801 ↗︎

@NevilleS NevilleS merged commit 44aa3bd into main Apr 16, 2024
13 checks passed
@NevilleS NevilleS deleted the ns-fix-privacy-policy-link branch April 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants