Added carets to collapsible sections in the overlay modal #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gilluminate
requested changes
Apr 18, 2024
There was a problem hiding this comment.
@guncha code looks great. The failing test should likely pass now if you pull in latest from main since that was fixed elsewhere. Also, would you mind taking a moment to update the change in the CHANGELOG.md file? Just take a look at what's already in there and mimic.
Passing run #7347 ↗︎
Details:
Review all test suite changes for PR #4793 ↗︎ |
||||||||||||||||||||
guncha
changed the title
|
@gilluminate assuming the checks will pass, this is ready to go! Just needs an approving review to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Cherry-picking the CSS used to implement an animated caret for the notice elements. See https://github.com/ethyca/fidesplus/pull/1374#discussion_r1556149459
Also changed CSS so that the caret will rotate the right way - counter clockwise on open.
Code Changes
Pre-Merge Checklist
CHANGELOG.md