PROD-1880 update data use and data subject columns to use friendly names #4774
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…Data-Use-and-Data-Subject-Columns-to-use-friendly-names
Passing run #7061 ↗︎
Details:
Review all test suite changes for PR #4774 ↗︎ |
|||||||||||||||
|
|
||
| import useFidesLang from "./useFidesLang"; | ||
|
|
||
| describe("Fides Language Helper Hook", () => { |
There was a problem hiding this comment.
Added unit tests testing the new 3 helper function in the hook. I wanted to do unit tests since this hook will probably get re-used across the ui to display the user-friendly names.
There was a problem hiding this comment.
Nice work on this, thank you!
lucanovera
changed the title
…olumns-to-use-friendly-names
There was a problem hiding this comment.
Great work on this! There are a lot of places in the UI that can be cleaned up to use the new hook for fetching display names, we do this kinda all over the place. I don't think it's worth doing as part of this ticket, but it's a good thing to keep in mind for future code cleanup. (Pointing it out here also for myself!)
|
|
||
| import useFidesLang from "./useFidesLang"; | ||
|
|
||
| describe("Fides Language Helper Hook", () => { |
There was a problem hiding this comment.
Nice work on this, thank you!
…se-friendly-names' of github.com:ethyca/fides into PROD-1880-Update-Data-Use-and-Data-Subject-Columns-to-use-friendly-names
lucanovera
deleted the
PROD-1880-Update-Data-Use-and-Data-Subject-Columns-to-use-friendly-names
branch
Description Of Changes
Display user friendly names for data use, categories and subjects in Data Map Report.
Code Changes
Screenshots
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md