Stripe integration updates for card #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7096 ↗︎
Details:
Review all test suite changes for PR #4768 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4768 +/- ##
=======================================
Coverage 69.47% 69.47%
=======================================
Files 519 519
Lines 25055 25055
Branches 2739 2739
=======================================
Hits 17408 17408
Misses 7168 7168
Partials 479 479 ☔ View full report in Codecov by Sentry. |
galvana
changed the title
galvana
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Hey @SteveDMurphy please take a look at my changes, we can merge this if you sign off on it
galvana
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Thanks for reviewing this again @SteveDMurphy, this looks good to me!
SteveDMurphy
commented
Apr 8, 2024
| method: POST | ||
| delete: | ||
| method: DELETE | ||
| ignore_errors: [404] # ignore errors if the card no longer exists |
There was a problem hiding this comment.
included ignoring a 404 here, we ignore others already and this helps resolve errors for cards not found when a user approves two erasure requests simultaneously @galvana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FIDES-581
Description Of Changes
The Card endpoint for Stripe no longer supports country, this is being removed along with changing the endpoint to a delete instead of update due to card expiration dates casuing issues.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md