-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Admin UI update - New field to accept this value #4761
Merged
gilluminate
merged 6 commits into
main
from
PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value
Apr 1, 2024
Merged
FE Admin UI update - New field to accept this value #4761
gilluminate
merged 6 commits into
main
from
PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6994 ↗︎
Details:
Review all test suite changes for PR #4761 ↗︎ |
eastandwestwind
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small nits, mostly want to agree on naming of the new var. Thanks!
clients/admin-ui/src/features/privacy-experience/PrivacyExperienceTranslationForm.tsx
Outdated
Show resolved
Hide resolved
gilluminate
force-pushed
the
PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value
branch
from
April 1, 2024 16:34
4b6a86d
to
370e9a1
Compare
eastandwestwind
approved these changes
Apr 1, 2024
gilluminate
deleted the
PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value
branch
April 1, 2024 18:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-1709
Description Of Changes
Adds new field to the translation form for Trigger Link Label. This allows users to set the language of the link that opens the Fides modal on their site.
Code Changes
trigger_link_label
to the type definitions ofExperienceTranslationCreate
andExperienceTranslation
schema.trigger_link_label
to form inclusionsSteps to Confirm
Pre-Merge Checklist