Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Admin UI update - New field to accept this value #4761

Merged

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Mar 29, 2024

Closes PROD-1709

Description Of Changes

Adds new field to the translation form for Trigger Link Label. This allows users to set the language of the link that opens the Fides modal on their site.

Code Changes

  • adds new trigger_link_label to the type definitions of ExperienceTranslationCreate and ExperienceTranslation schema.
  • adds new trigger_link_label to form inclusions
  • adds new field to the Admin UI translation form (WIP. Not hooked up to BE yet)

Steps to Confirm

  • Open an experience in Admin UI
  • Select a language from the sidebar
  • Scroll to the bottom and add a new label to the Trigger Link Label field

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 5:50pm

Copy link

cypress bot commented Mar 29, 2024

Passing run #6994 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 99a75bb into f8a9215...
Project: fides Commit: 6de19bdb69 ℹ️
Status: Passed Duration: 00:34 💡
Started: Apr 1, 2024 6:01 PM Ended: Apr 1, 2024 6:02 PM

Review all test suite changes for PR #4761 ↗︎

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small nits, mostly want to agree on naming of the new var. Thanks!

@gilluminate gilluminate force-pushed the PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value branch from 4b6a86d to 370e9a1 Compare April 1, 2024 16:34
@gilluminate gilluminate merged commit 3ff188b into main Apr 1, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-1709-fe-admin-ui-update-new-field-to-accept-this-value branch April 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants