Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cookie House to support for additional locations (Canada, Quebec, EEA) and a "property_id" override #4750

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Mar 27, 2024

Related to PROD-1862

Description Of Changes

This is a small update to the Cookie House sample app for demo purposes. It allows selecting a few extra locations (Canada, Quebec, EEA) and also lets you add a property_id= query param to the URL, which'll get passed along to the fides.js script include. Combined, you can use this to demo a lot more advanced consent experiences 👍

Code Changes

  • Add Canada, Quebec, and EEA options to the GeolocationSelect component
  • Add property_id to supported query params for fides.js script tag

Steps to Confirm

  • Run nox -s "fides_env(test)" to bring up the fides deploy sample project
  • Try out the Cookie House and inspect the network tab to confirm that the geolocation and property_id params are passed along to fides.js script tag

image

Pre-Merge Checklist

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 9:37pm

@NevilleS NevilleS marked this pull request as ready for review March 27, 2024 21:30
Copy link

cypress bot commented Mar 27, 2024

Passing run #6916 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge bcc5a30 into 20c2567...
Project: fides Commit: b3fa16bcd6 ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 27, 2024 9:49 PM Ended: Mar 27, 2024 9:49 PM

Review all test suite changes for PR #4750 ↗︎

@NevilleS NevilleS merged commit 09aa16d into main Mar 27, 2024
13 checks passed
@NevilleS NevilleS deleted the ns-update-sample-app-locations-properties branch March 27, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants