-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rounded corners and accessibility highlights on reporting column headers #4730
Remove rounded corners and accessibility highlights on reporting column headers #4730
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #6824 ↗︎
Details:
Review all test suite changes for PR #4730 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think of these suggestions. UAT passing!
…bility-highlights-on-reporting-column-headers
…bility-highlights-on-reporting-column-headers
_focusVisible={{ | ||
backgroundColor: "gray.100", | ||
}} | ||
_focus={{ | ||
outline: "none", | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kelsey-Ethyca I ended up using the less invasive focus-visible
for the bg color, which tends to only apply when user is tabbing with the keyboard and not when clicking. Hopefully this is a nice compromise.
…bility-highlights-on-reporting-column-headers
Closes #
Description Of Changes
Takes a few scattered styles for defining headers/cells and combines them a little better. Also removes the sorting for now.
Code Changes
getTableTHandTDStyles
util to include headers that act as buttonsgetTableTHandTDStyles
using Chakra's spacing definitions (for consistency) as well as acalc
to account for the width of the column resizersx
function as opposed to hard coding thestyle
property in several instances.Steps to Confirm
/consent/properties
has a table with 3 types of headers. It's a good one to look at for styling consistency.Pre-Merge Checklist
CHANGELOG.md
(https://github.com/ethyca/fides/blob/main/docs/fides/docs/development/postman/Fides.postman_collection.json) has been updated