Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal preview in Admin-UI experience config #4712

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

eastandwestwind
Copy link
Contributor

Closes #

Description Of Changes

Fix issue found in in UAT doc:

Privacy Experience Preview - display is showing banner for modal only experience type

Code Changes

  • set appropriate component config when in modal preview
  • remove need for fidesPreviewComponent config var

Steps to Confirm

Pre-Merge Checklist

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 8:59pm

Copy link

cypress bot commented Mar 14, 2024

Passing run #6682 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ce28d12 into 6b6e279...
Project: fides Commit: fa548310d1 ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 14, 2024 8:26 PM Ended: Mar 14, 2024 8:27 PM

Review all test suite changes for PR #4712 ↗︎

Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly ✅

Screen.Recording.2024-03-14.at.1.29.02.PM.mov

@Kelsey-Ethyca Kelsey-Ethyca merged commit 0a57252 into main Mar 14, 2024
9 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the fix-modal-preview-mode branch March 14, 2024 20:56
Kelsey-Ethyca added a commit that referenced this pull request Mar 14, 2024
@cypress cypress bot mentioned this pull request Mar 14, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants