-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to delete properties #4708
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6806 ↗︎
Details:
Review all test suite changes for PR #4708 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4708 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 337 337
Lines 19977 19977
Branches 2551 2551
=======================================
Hits 17308 17308
Misses 2201 2201
Partials 468 468 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TDD for the win! Lovely!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just little nits and questions. Can you get CI tests passing? UAT passing!
import { getErrorMessage, isErrorResult } from "../common/helpers"; | ||
import { PROPERTIES_ROUTE } from "../common/nav/v2/routes"; | ||
import Restrict from "../common/Restrict"; | ||
import { errorToastParams, successToastParams } from "../common/toast"; | ||
import { useDeletePropertyMutation } from "./property.slice"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { getErrorMessage, isErrorResult } from "../common/helpers"; | |
import { PROPERTIES_ROUTE } from "../common/nav/v2/routes"; | |
import Restrict from "../common/Restrict"; | |
import { errorToastParams, successToastParams } from "../common/toast"; | |
import { useDeletePropertyMutation } from "./property.slice"; | |
import { getErrorMessage, isErrorResult } from "~/features/common/helpers"; | |
import { PROPERTIES_ROUTE } from "~/features/common/nav/v2/routes"; | |
import Restrict from "~/features/common/Restrict"; | |
import { errorToastParams, successToastParams } from "~/features/common/toast"; | |
import { useDeletePropertyMutation } from "~/features/properties/property.slice"; |
clients/admin-ui/src/features/properties/DeletePropertyModalTrigger.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/properties/DeletePropertyModalTrigger.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @Kelsey-Ethyca! I made the changes you recommended and fixed the CI/CD issues. Ready for round 2!
Closes PROD-1664
Description Of Changes
Adding the ability to delete properties, only available to owners and contributors. Verifies that all of the experiences on the property are unlinked before being able to delete the property.
Code Changes
plus_property
,plus_privacy_experience_config_property
to avoid putting the property/privacy_experience_config entries into an invalid stateSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md