-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterable Erasure Integration #4695
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #7013 ↗︎
Details:
Review all test suite changes for PR #4695 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4695 +/- ##
==========================================
- Coverage 86.64% 86.64% -0.01%
==========================================
Files 338 338
Lines 19993 19993
Branches 2555 2555
==========================================
- Hits 17323 17322 -1
Misses 2201 2201
- Partials 469 470 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments but overall this is looking good 👍
Fixed placement of addition Co-authored-by: Adrian Galvan <[email protected]>
Closes #
Description Of Changes
Write some things here about the changes and any potential caveats
Code Changes
Pre-PR checklist
connector_params
identity_email
oridentity_phone_number
https://github.com/ethyca/fidesdocs/pull/334
https://github.com/ethyca/fidesdocs/issues/335
https://ethyca.atlassian.net/wiki/spaces/EN/pages/2968092673/Iterable+Integration+Specification
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md