Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-value support for custom privacy request fields #4686

Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Mar 12, 2024

Closes PROD-1802

Description Of Changes

Adding support for multi-value custom privacy request fields (integers and strings). This PR only covers the affected API endpoints and the part of the Admin UI responsible for displaying the custom fields. Changes to allow the Privacy Center forms to support multi-values fields is covered here https://ethyca.atlassian.net/browse/PROD-1807.

Code Changes

  • Updating the Admin UI to display custom privacy request field values correctly as comma separated values
  • Updated the functions responsible for caching and persisting custom values to the database to support lists
  • Updated the assign_placeholders util function to support list values
  • Updated related tests and added multi-value scenarios

Steps to Confirm

Pre-Merge Checklist

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:05pm

Copy link

cypress bot commented Mar 12, 2024

Passing run #6791 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5c3f28c into ccd14a7...
Project: fides Commit: 1ba111379e ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 20, 2024 8:37 PM Ended: Mar 20, 2024 8:38 PM

Review all test suite changes for PR #4686 ↗︎

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.64%. Comparing base (ccd14a7) to head (5c3f28c).

Files Patch % Lines
src/fides/api/models/privacy_request.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4686   +/-   ##
=======================================
  Coverage   86.63%   86.64%           
=======================================
  Files         337      337           
  Lines       19977    19990   +13     
  Branches     2551     2555    +4     
=======================================
+ Hits        17308    17320   +12     
  Misses       2201     2201           
- Partials      468      469    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good @galvana small comments and questions -

Copy link
Contributor Author

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional testing 🙏 ! I answered your questions and added the extra use cases. Ready for round 2

@galvana galvana requested a review from pattisdr March 20, 2024 19:39
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @galvana

@galvana galvana merged commit 0b1b994 into main Mar 21, 2024
18 checks passed
@galvana galvana deleted the PROD-1802-support-for-multivalue-custom-privacy-request-fields branch March 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants