-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-value support for custom privacy request fields #4686
Multi-value support for custom privacy request fields #4686
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…acy-request-fields
Passing run #6791 ↗︎
Details:
Review all test suite changes for PR #4686 ↗︎ |
…acy-request-fields
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4686 +/- ##
=======================================
Coverage 86.63% 86.64%
=======================================
Files 337 337
Lines 19977 19990 +13
Branches 2551 2555 +4
=======================================
+ Hits 17308 17320 +12
Misses 2201 2201
- Partials 468 469 +1 ☔ View full report in Codecov by Sentry. |
…acy-request-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good @galvana small comments and questions -
clients/admin-ui/src/features/privacy-requests/ApprovePrivacyRequestModal.tsx
Show resolved
Hide resolved
tests/ops/integration_tests/test_integration_custom_privacy_request_fields.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional testing 🙏 ! I answered your questions and added the extra use cases. Ready for round 2
clients/admin-ui/src/features/privacy-requests/ApprovePrivacyRequestModal.tsx
Show resolved
Hide resolved
tests/ops/integration_tests/test_integration_custom_privacy_request_fields.py
Outdated
Show resolved
Hide resolved
…acy-request-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work @galvana
Closes PROD-1802
Description Of Changes
Adding support for multi-value custom privacy request fields (integers and strings). This PR only covers the affected API endpoints and the part of the Admin UI responsible for displaying the custom fields. Changes to allow the Privacy Center forms to support multi-values fields is covered here https://ethyca.atlassian.net/browse/PROD-1807.
Code Changes
assign_placeholders
util function to support list valuesSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md