-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-1698: Bump Node.js base image from 16 to 20 LTS (fides) #4684
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #7451 ↗︎
Details:
Review all test suite changes for PR #4684 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4684 +/- ##
==========================================
- Coverage 86.88% 86.87% -0.01%
==========================================
Files 345 345
Lines 20785 20854 +69
Branches 2718 2726 +8
==========================================
+ Hits 18059 18117 +58
- Misses 2252 2262 +10
- Partials 474 475 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, taking in to consideration the following:
- I've been using v20 locally for nearly 2 months without issue.
- I've reviewed the CHANGELOGs and don't see anything substantial that would affect our builds.
- We don't use node as a server, just for build-time processes so the version upgrades don't tend to affect us as much anyway.
- All of the checks are passing in this PR, which is a huge indicator.
Closes PROD-1698 in
ethyca/fides
repoDescription Of Changes
16
to20
.Code Changes
Steps to Confirm
node -v
e.g.Pre-Merge Checklist
CHANGELOG.md