Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1698: Bump Node.js base image from 16 to 20 LTS (fides) #4684

Merged
merged 7 commits into from
May 8, 2024

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Mar 12, 2024

Closes PROD-1698 in ethyca/fides repo

Description Of Changes

Code Changes

  • Trivial version bumps, see commits.

Steps to Confirm

  • Exec into Docker image and run node -v e.g.
~ ❯ docker run -it -u 0 --entrypoint /bin/ash ethyca/fides-privacy-center:2.31.0
/fides/clients/privacy-center # node -v
v16.20.2

Pre-Merge Checklist

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 2:41pm

Copy link

cypress bot commented Mar 12, 2024

Passing run #7451 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ebe9026 into 7c665ca...
Project: fides Commit: e6546ed174 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 25, 2024 2:48 PM Ended: Apr 25, 2024 2:49 PM

Review all test suite changes for PR #4684 ↗︎

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (0f325d6) to head (ebe9026).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4684      +/-   ##
==========================================
- Coverage   86.88%   86.87%   -0.01%     
==========================================
  Files         345      345              
  Lines       20785    20854      +69     
  Branches     2718     2726       +8     
==========================================
+ Hits        18059    18117      +58     
- Misses       2252     2262      +10     
- Partials      474      475       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, taking in to consideration the following:

  1. I've been using v20 locally for nearly 2 months without issue.
  2. I've reviewed the CHANGELOGs and don't see anything substantial that would affect our builds.
  3. We don't use node as a server, just for build-time processes so the version upgrades don't tend to affect us as much anyway.
  4. All of the checks are passing in this PR, which is a huge indicator.

@gilluminate gilluminate merged commit 03a665b into main May 8, 2024
48 checks passed
@gilluminate gilluminate deleted the daveqnet/PROD-1698/node-bump branch May 8, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants