-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-1667 Link properties and experiences #4658
PROD-1667 Link properties and experiences #4658
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…roperties-and-experiences
…roperties-and-experiences
Passing run #6591 ↗︎
Details:
Review all test suite changes for PR #4658 ↗︎ |
…roperties-and-experiences
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## PROD-1458_multi_language_support #4658 +/- ##
====================================================================
+ Coverage 86.58% 86.60% +0.01%
====================================================================
Files 335 335
Lines 19867 19924 +57
Branches 2545 2549 +4
====================================================================
+ Hits 17202 17255 +53
- Misses 2198 2201 +3
- Partials 467 468 +1 ☔ View full report in Codecov by Sentry. |
…roperties-and-experiences
…roperties-and-experiences
…roperties-and-experiences
…roperties-and-experiences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BE is looking solid to me here too @galvana!
again, the only thing i'm a bit stuck on is just whether we can get rid of the cicular dep. i'm not trying to be a stickler here. but after looking through the code more closely, i'm pretty confident we could get rid of this without requiring any major restructuring. i feel that it's worthwhile - establishing a circular dependency in core DB models just doesn't feel great to me. we could always unwind it later, i'd just prefer we do it now.
happy to talk through that more. i won't hold this up if you're really feeling like it's not worth the effort!
Closes PROD-1667, PROD-1670
Description Of Changes
Adding the ability to bidirectionally link properties and privacy experience configs.
Code Changes
Property.key
usages toProperty.id
PrivacyExperienceForm
componentPropertyForm
componentplus_privacy_experience_config_property
linking tableProperty.experiences
andPrivacyExperienceConfig.properties
relationshipslink_properties_to_experience_config
andlink_experience_configs_to_property
Steps to Confirm
Properties
page and attempt to create a new property with a related experienceExperiences
page and verify the new property is visible in the related experiencePre-Merge Checklist
CHANGELOG.md