-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update privacy experiences table to new table component #4652
Update privacy experiences table to new table component #4652
Conversation
…' into PROD-1455-update-privacy-notices-table-to-new-table-component
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6490 ↗︎
Details:
Review all test suite changes for PR #4652 ↗︎ |
…-privacy-notices-table-to-new-table-component
@Kelsey-Ethyca I updated this PR to be merged into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all working locally 🙌 but I just have a few suggestions. Also, make sure to clean up the imports like I called out in your other PR.
clients/admin-ui/src/features/privacy-experience/PrivacyExperiencesTable.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-experience/PrivacyExperiencesTable.tsx
Outdated
Show resolved
Hide resolved
…ponent' into PROD-1459-update-privacy-experiences-table-to-new-table-component
…ponent' into PROD-1459-update-privacy-experiences-table-to-new-table-component
…-privacy-experiences-table-to-new-table-component
38fbf72
into
PROD-1458_multi_language_support
Closes #PROD-1459
Description Of Changes
Update privacy experiences page to use new table component
Before:
After:
Code Changes
PrivacyExperiencesTable
to use the new v2 tableSteps to Confirm
consent_multitranslation_plus
from https://github.com/ethyca/fidesplus/pull/1299 withnox -s "build(slim)" "dev(slim)" -- dev
cd client && turbo run dev
The sorting, searching, and filtering will be handled next sprint in https://ethyca.atlassian.net/browse/PROD-1772
Pre-Merge Checklist
CHANGELOG.md