Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update privacy experiences table to new table component #4652

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Mar 2, 2024

Closes #PROD-1459

Description Of Changes

Update privacy experiences page to use new table component

Before:
fides-plus-rc fides-staging ethyca com_consent_privacy-notices (3)

After:
localhost_3001_consent_privacy-experience

Code Changes

  • update PrivacyExperiencesTable to use the new v2 table
  • updates to privacy-experience/cells and v2/cells so the new notice table is working with the proper cells
  • update cypress tests to pass

Steps to Confirm

  • run plus branch consent_multitranslation_plus from https://github.com/ethyca/fidesplus/pull/1299 with nox -s "build(slim)" "dev(slim)" -- dev
  • run this branch with cd client && turbo run dev
  • nav to the experiences page
  • add systems with data uses
  • toggle notices enabled/disabled
  • click into experiences by clicking on the row
  • ensure the columns are correct - Location, Type, Last Update, Enable
  • ensure you can add and edit privacy experiences

The sorting, searching, and filtering will be handled next sprint in https://ethyca.atlassian.net/browse/PROD-1772

Pre-Merge Checklist

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 2:20am

Copy link

cypress bot commented Mar 2, 2024

Passing run #6490 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 73bd8fc into be55f45...
Project: fides Commit: 0885d0269a ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 5, 2024 2:29 AM Ended: Mar 5, 2024 2:30 AM

Review all test suite changes for PR #4652 ↗︎

@galvana galvana changed the base branch from PROD-1458_multi_language_support to PROD-1455-update-privacy-notices-table-to-new-table-component March 4, 2024 20:54
@galvana
Copy link
Contributor

galvana commented Mar 4, 2024

@Kelsey-Ethyca I updated this PR to be merged into PROD-1455-update-privacy-notices-table-to-new-table-component since that's the branch you based this PR on.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all working locally 🙌 but I just have a few suggestions. Also, make sure to clean up the imports like I called out in your other PR.

…ponent' into PROD-1459-update-privacy-experiences-table-to-new-table-component
Base automatically changed from PROD-1455-update-privacy-notices-table-to-new-table-component to PROD-1458_multi_language_support March 5, 2024 02:18
…-privacy-experiences-table-to-new-table-component
@Kelsey-Ethyca Kelsey-Ethyca merged commit 38fbf72 into PROD-1458_multi_language_support Mar 5, 2024
10 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1459-update-privacy-experiences-table-to-new-table-component branch March 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants