Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for GB country #4628

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Feb 21, 2024

Closes FIDES-454

Description Of Changes

  • include gb as a country

Code Changes

  • add GB as an option in all required locations

Steps to Confirm

  • Checked out the option on Fidesplus
image

Pre-Merge Checklist

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 2:28pm

Copy link

cypress bot commented Feb 21, 2024

Passing run #6325 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ffd29ba into 7774313...
Project: fides Commit: f6a3e3f214 ℹ️
Status: Passed Duration: 00:38 💡
Started: Feb 22, 2024 2:38 PM Ended: Feb 22, 2024 2:39 PM

Review all test suite changes for PR #4628 ↗︎

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7774313) 86.83% compared to head (ffd29ba) 86.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4628   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files         332      332           
  Lines       19979    19979           
  Branches     2569     2569           
=======================================
  Hits        17349    17349           
  Misses       2157     2157           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy SteveDMurphy self-assigned this Feb 22, 2024
@SteveDMurphy SteveDMurphy marked this pull request as ready for review February 22, 2024 14:31
@@ -661,6 +661,7 @@ def create_default_experience_config(
PrivacyNoticeRegion.sk,
PrivacyNoticeRegion.fi,
PrivacyNoticeRegion.se,
PrivacyNoticeRegion.gb,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do here, this is just a note to self: check if post-translation work we still want "gb" to be shown TCF Experiences.

I realize GB isn't in the EEA and I can't remember if we still added gb_* anyway because we wanted them to still see TCF Experiences. This list of EEA countries is going away in the new translation work, but this is just a note to make sure our post-translation changes that we still have the right regions we want on TCF.

@SteveDMurphy SteveDMurphy merged commit 303abec into main Feb 22, 2024
48 checks passed
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-fides-454-gb-experience branch February 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants