-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option for GB country #4628
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6325 ↗︎
Details:
Review all test suite changes for PR #4628 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4628 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 332 332
Lines 19979 19979
Branches 2569 2569
=======================================
Hits 17349 17349
Misses 2157 2157
Partials 473 473 ☔ View full report in Codecov by Sentry. |
@@ -661,6 +661,7 @@ def create_default_experience_config( | |||
PrivacyNoticeRegion.sk, | |||
PrivacyNoticeRegion.fi, | |||
PrivacyNoticeRegion.se, | |||
PrivacyNoticeRegion.gb, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to do here, this is just a note to self: check if post-translation work we still want "gb" to be shown TCF Experiences.
I realize GB isn't in the EEA and I can't remember if we still added gb_* anyway because we wanted them to still see TCF Experiences. This list of EEA countries is going away in the new translation work, but this is just a note to make sure our post-translation changes that we still have the right regions we want on TCF.
Closes FIDES-454
Description Of Changes
gb
as a countryCode Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md