Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CON-206: Responsys access and erasure #4618
CON-206: Responsys access and erasure #4618
Changes from 22 commits
5ef3ff3
5e15784
84d60c4
56fe5ca
2994673
878638c
645a5e3
0fb87b6
716303d
f17959d
b920a9a
2858a4b
5d5f760
13a2934
d44c054
de6fbef
e2de147
3f7208a
866f10a
06f559d
e7df930
4f99d18
db69147
2f445d3
0f93bbf
94a3397
1cc20cd
0d9d486
d2bbe0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This connector doesn't specify an icon so it falls back to the default

ethyca.svg
. This is how I noticed that the default icon has an unwanted fill. Just updating this so the entry looks good in the connector dropdown.With that said, do you want to add an icon for Oracle Responsys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an SVG, but I couldn't change the viewbox to
0 0 32 32
without clipping some of the SVG. @galvana, you have a way to do this, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about 'right' but typically we work with the icon in the figma page until we get it the way we like, then we can save it out to submit in the PR. We can walk through this pretty easy, but I can't lead just yet as I have requested access but don't have it yet =/
I found this icon that has both Oracle and Responsys in it but since I can't get into figma to verify if it will be easy to use or not =(

Check warning on line 33 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L32-L33
Check warning on line 45 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L42-L45
Check warning on line 47 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L47
Check warning on line 55 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L54-L55
Check warning on line 57 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L57
Check warning on line 60 in src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py
src/fides/api/service/saas_request/override_implementations/authentication_strategy_oracle_responsys.py#L59-L60
Check warning on line 46 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L45-L46
Check warning on line 48 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L48
Check warning on line 51 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L50-L51
Check warning on line 53 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L53
Check warning on line 57 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L56-L57
Check warning on line 59 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L59
Check warning on line 63 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L63
Check warning on line 65 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L65
Check warning on line 75 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L75
Check warning on line 91 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L90-L91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a good idea to break out the response processing into its own function so that we can test out some different scenarios. It's also a good way for someone to understand what's happening here if some sample test cases are provided.
Check warning on line 93 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L93
Check warning on line 107 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L107
Check warning on line 111 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L111
Check warning on line 114 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L113-L114
Check warning on line 117 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L117
Check warning on line 125 in src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
src/fides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py#L124-L125