Do not render nav until we are finished loading #4571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1592
Description Of Changes
The ticket req was to make the management tab in the nav open by default. The reason why it was starting off closed was because, in general, we have the following accordion groups:
However, 4. Consent only shows up in plus environments. To figure out if we are in a plus environment, we have to query for it first. During the query time, the nav only sees 4 options, so it says "open 4 accordion tabs" and by the time the plus query says "yes we have plus, render Consent", only the first 4 tabs open up.
Relatedly, Michael also commented a while back:
So, to feed two birds with one scone, we now render a blank nav until the plus query is ready. This makes sure that the management tab will open up, and also that the plus only menu options don't pop in later 🐦🍰🐦
Screen.Recording.2024-01-24.at.4.57.41.PM.mov
Code Changes
MainSideNav
, query for plus health. While that's loading, render an empty nav boxSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md