Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render nav until we are finished loading #4571

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 24, 2024

Closes https://ethyca.atlassian.net/browse/PROD-1592

Description Of Changes

The ticket req was to make the management tab in the nav open by default. The reason why it was starting off closed was because, in general, we have the following accordion groups:

  1. Overview
  2. Data map
  3. Privacy requests
  4. Consent
  5. Management

However, 4. Consent only shows up in plus environments. To figure out if we are in a plus environment, we have to query for it first. During the query time, the nav only sees 4 options, so it says "open 4 accordion tabs" and by the time the plus query says "yes we have plus, render Consent", only the first 4 tabs open up.

Relatedly, Michael also commented a while back:

Is there any way to delay showing everything until the page is fully ready? I think menu options for plus features pop in a bit later than the other items. I think it might look cleaner if we determine what to display, then once that determination is made, the fully formed nav is made visible.

So, to feed two birds with one scone, we now render a blank nav until the plus query is ready. This makes sure that the management tab will open up, and also that the plus only menu options don't pop in later 🐦🍰🐦

Screen.Recording.2024-01-24.at.4.57.41.PM.mov

Code Changes

  • In MainSideNav, query for plus health. While that's loading, render an empty nav box

Steps to Confirm

  • Load the admin-ui. The Management tab should start off open

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 10:41pm

Copy link

cypress bot commented Jan 24, 2024

Passing run #6069 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e4be494 into 10f8f0a...
Project: fides Commit: e12a2f6ee5 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jan 24, 2024 10:49 PM Ended: Jan 24, 2024 10:50 PM

Review all test suite changes for PR #4571 ↗︎

@allisonking allisonking marked this pull request as ready for review January 24, 2024 22:01
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a minor nit, but otherwise LGTM and good idea 👍

@allisonking allisonking merged commit 13a040e into main Jan 24, 2024
13 checks passed
@allisonking allisonking deleted the aking/prod-1594/management-nav branch January 24, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants