-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fides.js integrate with backend GPP fields #4559
Merged
allisonking
merged 14 commits into
aking/prod-1584/configure-gpp-ui
from
aking/prod-1588/fides-js-backend-gpp
Jan 23, 2024
Merged
Fides.js integrate with backend GPP fields #4559
allisonking
merged 14 commits into
aking/prod-1584/configure-gpp-ui
from
aking/prod-1588/fides-js-backend-gpp
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
allisonking
changed the base branch from
main
to
aking/prod-1584/configure-gpp-ui
January 17, 2024 19:46
Passing run #6030 ↗︎
Details:
Review all test suite changes for PR #4559 ↗︎ |
…fides-js-backend-gpp
…fides-js-backend-gpp
…fides-js-backend-gpp
eastandwestwind
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
allisonking
merged commit Jan 23, 2024
955e659
into
aking/prod-1584/configure-gpp-ui
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1588
Closes https://ethyca.atlassian.net/browse/PROD-1586
Description Of Changes
This is similar in nature to #4504. In that PR, I had hard coded a JSON obj that acted as a temporary measure while the backend privacy notices did not have GPP fields yet. https://github.com/ethyca/fidesplus/pull/1281 adds GPP fields to privacy notices, so this PR refactors fides.js to use the backend objects instead of the JSON obj.
https://www.loom.com/share/6a8515c666c446f4a537fc1964ca083c?sid=0c046f2e-c858-4200-a584-e6d0788f5911
Code Changes
supportedAPIs
populates—we've actually side stepped a bit here since we no longer want to specifyregions
in the backend toml, and instead derive that from our recent locations/regulations work (see here for context). however, that work isn't reconciled with this work yet, so this is hard coded for nowSteps to Confirm
This is a similar setup as but with some more backend integration.
asachs/gpp-config-api
withnox -s "build(slim)" -- dev_prerelease && nox -s dev
/management/consent
and enable GPP on the state level/consent/privacy-notices
and you should see some new privacy notices that say they are for GPP US States. Add a system with third party targeted advertising as a data use, then enable the equivalent privacy notice (see loom for example)localhost:3000/fides-js-demo.html
using a vpn to California__gpp('addEventListener', (data) => {console.log({data})})
uscav1
is in theparsedSections
For example
Also try US National
/management/consent
then switch GPP to the national level/consent/privacy-notices
and enable the National data sales/sharing noticelocalhost:3000/fides-js-demo.html
using a vpn to California__gpp('addEventListener', (data) => {console.log({data})})
usnatv1
is in theparsedSections
Pre-Merge Checklist
CHANGELOG.md