Updated nav #4548
Merged
Updated nav #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5956 ↗︎
Details:
Review all test suite changes for PR #4548 ↗︎ |
||||||||||||||||||||
|
@allisonking just to check, I'm still seeing the breadcrumb, is that to be expected? |
|
All looks good to me @allisonking apart from the margin around the back button. I have it set to 8px above and 12px below. Otherwise looks great. |
| html: { | ||
| height: "100%", | ||
| }, | ||
| "#__next": { |
There was a problem hiding this comment.
clever! This div has caused issues for me in the past.
There was a problem hiding this comment.
ah yes, I spent much time chasing down all the heights that needed to be 100%...
TheAndrewJackson
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1517
Description Of Changes
New nav ✨
Code Changes
_app.tsxsuch that the nav and header render on every page (except login) and fixedFixedLayoutwas)Layout's into oneLayout(which is mostlyFixedLayoutbut with the nav and header moved out into_app.tsx. It needs to be in_app.tsxotherwise you'll see flickering in the nav when you go between pages)Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md