Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set supportsOOB on tcModel to false #4516

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Set supportsOOB on tcModel to false #4516

merged 3 commits into from
Dec 18, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Dec 14, 2023 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/PROD-1530

Description Of Changes

Sets one of the flags on tcModel to false

Code Changes

  • Sets supportsOOB on tcModel to false

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 6:51pm

@cypress Cypress
Copy link

cypress bot commented Dec 14, 2023 •
edited
Loading

Passing run #5656 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge b026600 into 9e98d22...
Project: fides Commit: cdc0990000 ℹ️
Status: Passed Duration: 00:32 💡
Started: Dec 14, 2023 7:02 PM Ended: Dec 14, 2023 7:02 PM

Review all test suite changes for PR #4516 ↗︎

@allisonking allisonking marked this pull request as ready for review December 14, 2023 19:09
NevilleS
NevilleS approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@NevilleS NevilleS merged commit 6b66d42 into main Dec 18, 2023
13 checks passed
@NevilleS NevilleS deleted the aking/prod-1530/disable-oob branch December 18, 2023 19:32
@Kelsey-Ethyca
Copy link
Contributor

Kelsey-Ethyca commented Dec 20, 2023 •
edited
Loading

@NevilleS can you confirm you tested this.. setting supportOOB to false and verifying google ads doesn't flags it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonking @Kelsey-Ethyca @NevilleS