Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Add Vendor btn from Consent > Vendors page #4509

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Remove Add Vendor btn from Consent > Vendors page #4509

merged 4 commits into from
Dec 11, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

Code Changes

  • Remove Add Vendor btn from Consent > Vendors page

Steps to Confirm

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 8:15pm

@Kelsey-Ethyca
Copy link
Contributor Author

UAT https://www.loom.com/share/24da463c65c04b4ab01b67fe03b2e522

adamsachs
adamsachs approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this also looks good locally! 🚢
image

@cypress Cypress
Copy link

cypress bot commented Dec 11, 2023

Passing run #5608 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c3518c7 into 8a4a72d...
Project: fides Commit: 4d99c0f226 ℹ️
Status: Passed Duration: 00:32 💡
Started: Dec 11, 2023 8:20 PM Ended: Dec 11, 2023 8:21 PM

Review all test suite changes for PR #4509 ↗︎

@Kelsey-Ethyca Kelsey-Ethyca merged commit af2901a into main Dec 11, 2023
11 of 12 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1520-remove-add-vendor-btn branch December 11, 2023 20:21
Kelsey-Ethyca added a commit that referenced this pull request Dec 11, 2023
@Kelsey-Ethyca
Remove Add Vendor btn from Consent > Vendors page (#4509)
0fa4a12
@Kelsey-Ethyca Kelsey-Ethyca mentioned this pull request Dec 11, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @adamsachs