Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Compass button states #4508

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Fix Compass button states #4508

merged 5 commits into from
Dec 14, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Dec 11, 2023 •
edited
Loading

Closes #PROD-1449

Description Of Changes

Fixes a few bugged/incorrect states of the Compass button in the system information form:

  • The button is now highlighted in purple while suggestions are being made in the typeahead, instead of only when a vendor is selected
  • The button no longer has a hover state when it's disabled (i.e. if suggestions are already being shown, or if no vendor is selected)
  • The button is now a menu button

Code Changes

  • Changes to styling on VendorSelector component and its nested CompassButton
  • Changed some variable names to clarify what's a suggestion from the vendor selector and what's a suggestion from Compass for the form

Steps to Confirm

With Compass enabled:

  • Go to the "add a system" form
  • Type the name of a GVL vendor into the typeahead (e.g. "Adtelligence")
  • While the typeahead is showing a suggestion in purple, the Compass button should also be purple
  • Accept the suggestions for the vendor
  • Compass button should be disabled; mouse over button and confirm color doesn't change
  • Save the system
  • Make changes to the system, then save again
  • Click the Compass button, then "Update to Compass defaults"; original suggestions from Compass should be shown again

Loom demo

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 3:57pm

@cypress Cypress
Copy link

cypress bot commented Dec 11, 2023 •
edited
Loading

Passing run #5632 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6d45ac6 into b45b721...
Project: fides Commit: c1c08a0859 ℹ️
Status: Passed Duration: 00:35 💡
Started: Dec 13, 2023 4:07 PM Ended: Dec 13, 2023 4:08 PM

Review all test suite changes for PR #4508 ↗︎

@jpople jpople requested a review from allisonking December 11, 2023 20:24
allisonking
allisonking reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good! will UAT tomorrow, I promise I haven't forgotten about this PR 😄

@allisonking
Copy link
Contributor

UAT looks good to me!

Uploading Screen Recording 2023-12-13 at 9.12.54 AM.mov…

@allisonking
Copy link
Contributor

hmm video upload maybe isn't working? here's the video in slack: https://ethyca.slack.com/archives/C04S7K0T2V7/p1702477307106749

@jpople jpople requested a review from allisonking December 13, 2023 17:06
@jpople jpople merged commit d784a5c into main Dec 14, 2023
@jpople jpople deleted the jpople/prod-1449/compass-button-fixes branch December 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @allisonking