Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PyArrow #4486

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Remove PyArrow #4486

merged 3 commits into from
Dec 7, 2023

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Dec 5, 2023 •
edited by jira bot
Loading

PROD-1499

Description Of Changes

Code Changes

  • See commit (very simple one-liner)

Steps to Confirm

  • Ensure there's no regression of this issue: Fix Snowflake UserWarning #3433
  • Ensure that pyarrow is no longer listed in the dependency tree
  • Ensure that the bigquery bump has not broken any existing funcitonality.

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 1:45pm

@cypress Cypress
Copy link

cypress bot commented Dec 5, 2023 •
edited
Loading

Passing run #5516 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge f55ec1b into a8efadd...
Project: fides Commit: 24f76525df ℹ️
Status: Passed Duration: 00:34 💡
Started: Dec 6, 2023 1:54 PM Ended: Dec 6, 2023 1:55 PM

Review all test suite changes for PR #4486 ↗︎

@daveqnet daveqnet requested a review from SteveDMurphy December 5, 2023 18:18
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8efadd) 87.11% compared to head (f55ec1b) 87.11%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4486   +/-   ##
=======================================
  Coverage   87.11%   87.11%           
=======================================
  Files         331      331           
  Lines       20478    20478           
  Branches     2639     2639           
=======================================
  Hits        17839    17839           
  Misses       2172     2172           
  Partials      467      467

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SteveDMurphy
SteveDMurphy approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks sharp with BigQuery @daveqnet ! I did just want to do some further confirmation on the installation with Plus but not required here

@daveqnet daveqnet mentioned this pull request Dec 6, 2023
Closed
@daveqnet daveqnet changed the title Remove pyarrow dependency version pin Remove PyArrow Dec 6, 2023
@daveqnet daveqnet added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Dec 6, 2023
@daveqnet daveqnet merged commit 70011a7 into main Dec 7, 2023
@daveqnet daveqnet deleted the daveqnet/remove-pyarrow-pin branch December 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveDMurphy SteveDMurphy SteveDMurphy approved these changes

Assignees

@daveqnet daveqnet

Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveqnet @SteveDMurphy