Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF purpose override page #4484

Merged
merged 20 commits into from
Dec 6, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Dec 5, 2023

Closes PROD-1414 PROD-1427

Description Of Changes

Add new page to manage TCF override settings

demo_2.mov

Code Changes

  • Add new /management/consent page for TCF override configuration
  • add FE route handlers for new TCF purpose override endpoints
  • Add api_set param to ApplicationConfig route handler

Steps to Confirm

  • pull the latest main in fidesplus and set the prerelease-requirements.txt to 2.25.1a9
  • build with nox -s "build(slim)" -- dev_prerelease
  • Configure TCF to be enabled FIDES__CONSENT__TCF_ENABLED=True
  • run nox -s "dev(slim)
  • navigate to /management/consent
  • enable TCF overrides
  • toggle some purposes on
  • Have some require consent and make sure that legit interest is disabled
  • have some require legit interest and make sure that requires consent is disabled
  • turn off one of the purposes and make sure that both consent and legit interest are disabled
  • save and reload the page. Make sure changes stay
  • toggle overrides off then back on again. Make sure all the overrides were reset

Pre-Merge Checklist

@TheAndrewJackson TheAndrewJackson self-assigned this Dec 5, 2023
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 7:42pm

Copy link

cypress bot commented Dec 5, 2023

Passing run #5522 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 47cdeec into a8efadd...
Project: fides Commit: fb4b2f5b3d ℹ️
Status: Passed Duration: 00:32 💡
Started: Dec 6, 2023 7:51 PM Ended: Dec 6, 2023 7:52 PM

Review all test suite changes for PR #4484 ↗︎

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked as expected! I just called out some typos and design misses.

clients/admin-ui/src/pages/management/consent.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/pages/management/consent.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/pages/management/consent.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/pages/management/consent.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/pages/management/consent.tsx Outdated Show resolved Hide resolved
@TheAndrewJackson
Copy link
Contributor Author

@galvana UAT feedback from Michael that's been applied:

  • Update column header text
  • Update update text to vendor overrides in toast
  • Update guide link to say vendor overrides and link out to bit.ly link
  • Add tooltip to override toggle
  • Fix casing throughout the page (I double checked the casing on the designs with the page )
  • update the Ethyca support link to be a mailto link
  • update override toggle positioning

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@TheAndrewJackson TheAndrewJackson merged commit 646a625 into main Dec 6, 2023
43 of 46 checks passed
@TheAndrewJackson TheAndrewJackson deleted the ajackson/PROD-1414_PROD_1427/override_table branch December 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants