Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase max number of preferences in privacy preference API models #4469

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Nov 30, 2023

Closes PROD-1472

Description Of Changes

Increases # of preferences allowed in /privacy-preference API model, to support 1k+ system use cases.

Note that we have concerns about the scalability of this data model and will likely need to think about a more sustainable path forward. For now, this can unblock the use case in the immediate term.

Follow-up ticket will be incoming...

Code Changes

  • increase max_items param for our preferences attributes on our preference API models.

Steps to Confirm

  • need to integrate with fidesplus endpoints if we wish to test, but the code change here should be pretty straightforward....

Pre-Merge Checklist

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 4:06pm

Copy link

cypress bot commented Nov 30, 2023

Passing run #5408 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8614ca6 into 0f06766...
Project: fides Commit: f3a0909929 ℹ️
Status: Passed Duration: 00:35 💡
Started: Nov 30, 2023 9:48 PM Ended: Nov 30, 2023 9:49 PM

Review all test suite changes for PR #4469 ↗︎

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f06766) 87.10% compared to head (8614ca6) 87.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4469   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         329      329           
  Lines       20386    20386           
  Branches     2627     2627           
=======================================
  Hits        17758    17758           
  Misses       2163     2163           
  Partials      465      465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs marked this pull request as ready for review December 5, 2023 16:05
@adamsachs
Copy link
Contributor Author

going to go ahead and merge this for now to remove this constraint as a blocker. but there are other known issues with saving consent preferences with many system/vendor records, and there are ongoing refactors (https://github.com/ethyca/fidesplus/pull/1249) that likely make the change here unnecessary!

@adamsachs adamsachs merged commit a7be4d9 into main Dec 5, 2023
@adamsachs adamsachs deleted the asachs/PROD-1472 branch December 5, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants