Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend TCF Purpose Override Support #4464
Backend TCF Purpose Override Support #4464
Changes from 6 commits
349d0ee
b0637f3
ff4b6e6
4d3c1b8
8e4235e
a6c099f
64a14c2
8bb1af3
5b40058
9c97f2d
e6ea2da
09e6f1a
a3b0aca
16892f0
a46a2ec
563d52d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 261 in src/fides/api/api/v1/endpoints/system.py
Codecov / codecov/patch
src/fides/api/api/v1/endpoints/system.py#L261
Check warning on line 364 in src/fides/api/api/v1/endpoints/system.py
Codecov / codecov/patch
src/fides/api/api/v1/endpoints/system.py#L363-L364
Check warning on line 385 in src/fides/api/api/v1/endpoints/system.py
Codecov / codecov/patch
src/fides/api/api/v1/endpoints/system.py#L384-L385
Check warning on line 406 in src/fides/api/api/v1/endpoints/system.py
Codecov / codecov/patch
src/fides/api/api/v1/endpoints/system.py#L406
Check warning on line 210 in src/fides/api/app_setup.py
Codecov / codecov/patch
src/fides/api/app_setup.py#L210
Check warning on line 270 in src/fides/api/app_setup.py
Codecov / codecov/patch
src/fides/api/app_setup.py#L265-L270
Check warning on line 272 in src/fides/api/app_setup.py
Codecov / codecov/patch
src/fides/api/app_setup.py#L272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm sort of curious how these get compiled into the generated SQL queries! if you have something handy i'd love to see, but no need to go out of your way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a CASE statement added to the other SELECT attributes, it's not bad! We can explore adding purpose too on the declaration at some point in the future. Cons are keeping data use/purpose in sync though.