Gong access and erasure #4461
Gong access and erasure #4461
Conversation
data/saas/config/gong_config.yml
Outdated
| connector_params: | ||
| - name: domain | ||
| default: api.gong.io | ||
| - name: basic token |
There was a problem hiding this comment.
We should prompt the user for access_key and access_key_secret since that's what we use for basic authentication below. Only access_key_secret should be flagged with sensitive: True
There was a problem hiding this comment.
Made these changes.
data/saas/config/gong_config.yml
Outdated
|
|
||
| connector_params: | ||
| - name: domain | ||
| default: api.gong.io |
There was a problem hiding this comment.
Typo here, it should be default_value and make sure to tab it in to line up with name
data/saas/config/gong_config.yml
Outdated
| - name: domain | ||
| default: api.gong.io | ||
| - name: basic token | ||
| description: Check Gong's documentation for how to create this value https://us-66708.app.gong.io/settings/api/documentation#overview |
There was a problem hiding this comment.
We can just use https://app.gong.io/settings/api/documentation#overview here, try not to put our Ethyca-specific URLs in the descriptions if possible
data/saas/config/gong_config.yml
Outdated
| path: /v2/data-privacy/erase-data-for-email-address | ||
| body: | | ||
| { | ||
| "emailAddress": <delemail> |
There was a problem hiding this comment.
make sure to include the param_values here and replace <delemail> with "<email>"
param_values:
- name: email
identity: email
tests/fixtures/saas/gong_fixtures.py
Outdated
| def gong_secrets(saas_config) -> Dict[str, Any]: | ||
| return { | ||
| "domain": pydash.get(saas_config, "gong.domain") or secrets["domain"], | ||
| # add the rest of your secrets here |
There was a problem hiding this comment.
Remove this comment after you add in your secrets
tests/fixtures/saas/gong_fixtures.py
Outdated
|
|
||
| @pytest.fixture | ||
| def gong_external_references() -> Dict[str, Any]: | ||
| return {} |
There was a problem hiding this comment.
If you don't use any of these placeholder fixtures (they just return {}) then you can delete the entire fixture and remove them as a parameter from the gong_runner function below
| ) | ||
| assert access_results == {"gong_instance:user": 1} | ||
|
|
||
| async def test_strict_erasure_request( |
There was a problem hiding this comment.
We can remove this since we're going to use deletes (non-strict erasure)
data/saas/icon/gong.svg
Outdated
There was a problem hiding this comment.
This icon needs to be 32 x 32 units in Figma and have 2 units of padding all around
There was a problem hiding this comment.
Okay, I think I fixed it.
Here is what I am not clear on, do we mean that the icon frame has to be 32x32 (and can not be smaller?). Then I want to have the picture (without any fill) within the frame with 2 spaces of padding all around? I had been making them 28x28 I thought it was 4 spaces of padding all around.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #5492 ↗︎
Details:
Review all test suite changes for PR #4461 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4461 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 329 329
Lines 20386 20386
Branches 2627 2627
=======================================
Hits 17758 17758
Misses 2163 2163
Partials 465 465 ☔ View full report in Codecov by Sentry. |
Closes #CON-108
Description Of Changes
Adding support for a new connector for Gong
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/295
https://github.com/ethyca/fidesdocs/issues/294
CHANGELOG.md