Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selected value color in "configure consent" vendor select dropdown #4454

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 22, 2023

Closes #PROD-1205

Description Of Changes

Fixed the color of the selected entry in the vendor dropdown of the "configure consent" page to be correct according to designs.

Screenshot 2023-11-22 at 10 43 51 AM

Focus color issue noted in the comments here turned out to be non-trivial, so followup issue is here.

Steps to Confirm

On "configure consent" page with dictionary enabled:

  • Open "add vendor" modal
  • Select a vendor
  • Click "vendor" field to select another vendor
  • Vendor you just selected should be highlighted in gray

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 5:54pm

@jpople jpople changed the title update selected value color in dropdown Update selected value color in "configure consent" vendor select dropdown Nov 22, 2023
Copy link

cypress bot commented Nov 22, 2023

Passing run #5346 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a2a3338 into 1459323...
Project: fides Commit: 8b2bed6651 ℹ️
Status: Passed Duration: 00:32 💡
Started: Nov 22, 2023 6:05 PM Ended: Nov 22, 2023 6:05 PM

Review all test suite changes for PR #4454 ↗︎

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm! I also checked how it would impact other components, but it looks like no other component actually supplies a list to select from other than this one 👍

@jpople jpople merged commit d1ff5f6 into main Nov 22, 2023
@jpople jpople deleted the jpople/prod-1205/vendor-reselection-styling branch November 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants