Support for consent management report #4452
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
||
|
|
||
| def upgrade(): | ||
| op.execute("CREATE EXTENSION IF NOT EXISTS pg_trgm;") |
There was a problem hiding this comment.
The pg_trgm extension has been available since Postgres 8.3 so we should be ok to enable it
| op.create_index( | ||
| "ix_ctl_systems_name", | ||
| "ctl_systems", | ||
| [sa.text("name gin_trgm_ops")], | ||
| postgresql_using="gin", |
There was a problem hiding this comment.
Adds a GIN index to be able to do a partial search on system name (%name%)
|
|
||
| @router.get( | ||
| "/purposes", | ||
| dependencies=[Security(verify_oauth_client)], |
There was a problem hiding this comment.
Not tied to any scope, this is available for any authenticated user
| @@ -112,6 +112,9 @@ | |||
| "/privacy-request/transfer/{privacy_request_id}/{rule_key}" | |||
| ) | |||
|
|
|||
| # Purpose URLs | |||
| PURPOSES = "/purposes" | |||
There was a problem hiding this comment.
Not sure if it's best to make this its own URL or if it should go under an existing path
Passing run #5338 ↗︎
Details:
Review all test suite changes for PR #4452 ↗︎ |
||||||||||||||||||||
| from fides.common.api.v1.urn_registry import PURPOSES, V1_URL_PREFIX | ||
|
|
||
|
|
||
| class TestGetPurposes: |
There was a problem hiding this comment.
Simple test that just checks access based on auth header
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
+ Coverage 87.10% 87.11% +0.01%
==========================================
Files 329 330 +1
Lines 20366 20390 +24
Branches 2623 2625 +2
==========================================
+ Hits 17739 17762 +23
- Misses 2163 2164 +1
Partials 464 464 ☔ View full report in Codecov by Sentry. |
Description Of Changes
Adds a GIN index on
ctl_systems.nameand a new/purposesendpoint to support the new consent management report tableCode Changes
ctl_systems/purposesendpoint that returns a map of purpose and special purpose IDs to mapped purposes (purpose info + data uses)Steps to Confirm
https://localhost:8080/docsGET /purposesendpointPre-Merge Checklist
CHANGELOG.md