Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating consent modal to hide the opt-in/opt-out buttons if only one privacy notice is enabled #4441

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Updating consent modal to hide the opt-in/opt-out buttons if only one privacy notice is enabled #4441

merged 3 commits into from
Nov 22, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 20, 2023 •
edited
Loading

Code Changes

  • Updating NoticeOverlay and ConsentButtons components

Steps to Confirm

  • Configure a system with the analytics and essential data uses
  • Navigate to Consent > Privacy Notices and enable Analytics
  • Navigate to http://localhost:3000/fides-js-demo.html and click on Manage preferences
  • Verify only the save button is displayed
  • Navigate to Consent > Privacy Notices and enable Essential
  • Navigate to http://localhost:3000/fides-js-demo.html and click on Manage preferences
  • Verify all three buttons are displayed

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 1:29am

@galvana galvana marked this pull request as ready for review November 20, 2023 03:20
@cypress Cypress
Copy link

cypress bot commented Nov 20, 2023 •
edited
Loading

Passing run #5319 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 00fd521 into ef64409...
Project: fides Commit: 0d903f0675 ℹ️
Status: Passed Duration: 00:32 💡
Started: Nov 21, 2023 5:05 PM Ended: Nov 21, 2023 5:05 PM

Review all test suite changes for PR #4441 ↗︎

@galvana galvana requested a review from allisonking November 21, 2023 16:54
allisonking
allisonking approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 💯

Save only
image

Multiple options
image

Acknowledge still has just the OK button
image

@galvana galvana merged commit 533cc27 into main Nov 22, 2023
@galvana galvana deleted the PROD-1233-update-consent-modal branch November 22, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @allisonking