Add confirmation modal on deleting a privacy declaration #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5307 ↗︎
Details:
Review all test suite changes for PR #4439 ↗︎ |
||||||||||||||||||||
allisonking
approved these changes
Nov 20, 2023
Comment on lines
621
to
625
| cy.fixture("systems/system.json").then((system) => { | ||
| cy.intercept("GET", "/api/v1/system/*", { | ||
| body: systems[0], | ||
| }).as("getFidesctlSystemWithDataUses"); | ||
| body: system, | ||
| }).as("getDemoAnalyticsSystem"); | ||
| }); |
There was a problem hiding this comment.
I think now that we aren't manipulating the fixture, this can be simplified to
cy.intercept("/api/v1/system/*", {
fixture: "systems/system.json"
}).as("getDemoAnalyticsSystem");| ); | ||
| }); | ||
|
|
||
| cy.getByTestId("tab-Data uses").click(); | ||
| }); | ||
|
|
||
| it("can visit the privacy declaration tab", () => { |
There was a problem hiding this comment.
nit: it feels a little weird for this test to be under the "delete privacy declaration" section
| </Text> | ||
| , including all its cookies. Are you sure you want to | ||
| continue? | ||
| </Text> |
There was a problem hiding this comment.
I didn't see a design in the original ticket, but our modals have been skewing "centered" on the page with the isCentered prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-1317
Description Of Changes
Adds a confirmation modal on deleting a data use which warns the user that the data use and cookies will be deleted.
Steps to Confirm
Loom video
Pre-Merge Checklist
CHANGELOG.md