Flexible Legal Basis = True Default #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update PrivacyDeclaration.flexible_legal_basis_for_processing to get rid of the third state. Make it required, and set the server default to True, to match what should happen when systems are created outside of Compass. - Add a migration that first updates existing flexible_legal_basis_for_processing to False if it is currently null, then adds the new server default and makes it required.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
pattisdr
commented
Nov 15, 2023
pattisdr
commented
Nov 15, 2023
Passing run #5260 ↗︎
Details:
Review all test suite changes for PR #4434 ↗︎ |
||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
=======================================
Coverage 87.10% 87.10%
=======================================
Files 329 329
Lines 20358 20358
Branches 2621 2621
=======================================
Hits 17733 17733
Misses 2162 2162
Partials 463 463 ☔ View full report in Codecov by Sentry. |
6 tasks
|
@adamsachs I think this is ready to go, just need a 👍 |
Looks good - does changelog need to be updated? |
adamsachs
approved these changes
Nov 16, 2023
|
thank you for the changelog catch, I thought I'd done it, but just in fideslang! |
pattisdr
deleted the
PROD-1264_flexible_legal_basis_for_processing_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗
Contains migration; check downrev❗
Dependent on fideslang release of https://github.com/ethyca/fideslang/pull/184Closes #PROD-1264
Description Of Changes
Make "flexible legal basis for processing" non nullable and True by default in the backend.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md