PROD-1389 for TCF, any consent pref that is not defined on cookie should be assumed opt-out #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
allisonking
reviewed
Nov 14, 2023
clients/fides-js/src/lib/cookie.ts
Outdated
| : // If experience contains a tcf entity not defined by tcfEntities, this means either: | ||
| // A) Most commonly, user has opted out, and opt-outs are not tracked by TC string. It's safe to assume this case. | ||
| // B) There is a new tcf entity that requires consent. In this case we would just resurface the banner | ||
| ConsentMechanism.OPT_OUT; |
There was a problem hiding this comment.
I think we only want this for the fides string override case. in other words, I think this change would break this flow:
- No fides string override
- User opts out of all purposes
- A new legint purpose is added
- On load, the new legint purpose would be opted out, even though in this case, because we have the cookie key consent, we actually know the user has not opted out.
I think this could be fixed with...
const defaultPreference = cookie.fides_string ? ConsentMechanism.OPT_OUT : item.default_preference;
const preference = Object.hasOwn(cookieConsent, item.id)
? transformConsentToFidesUserPreference(
Boolean(cookieConsent[item.id]),
ConsentMechanism.OPT_IN
)
: defaultPreference;There was a problem hiding this comment.
Ah this makes more sense, thanks @allisonking !
Passing run #5246 ↗︎
Details:
Review all test suite changes for PR #4430 ↗︎ |
||||||||||||||||||||
allisonking
approved these changes
Nov 14, 2023
eastandwestwind
added a commit
that referenced
this pull request
Nov 14, 2023
…uld be assumed opt-out (#4430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1389
Description Of Changes
For TCF, if we have a previously saved
fides_consentcookie or afides_stringoverride, any consent pref that is not defined on cookie.tcf_consent should be assumed opt-out, instead of using the defaults on the experience.Code Changes
cookietoo).Steps to Confirm
?fides_stringquery param to the URL, e.g. http://localhost:3000/fides-js-components-demo.html?fides_string=CP1OzUAP1OzUAGXABBENATEgAAAAAAAAAAAAAAAAAAAA.IABE,1~Pre-Merge Checklist
CHANGELOG.md