Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsig access and erasure #4429

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Statsig access and erasure #4429

merged 17 commits into from
Dec 14, 2023

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Nov 14, 2023

Closes #CON-203

Description Of Changes

Adding a new erasure connector for Statsig

Code Changes

  • Added required files for the addition of an Erasure only connector for Statsig

Steps to Confirm

  • Ensure we can now add this new connector to a system from the Fides interface

Pre-Merge Checklist

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 6:32pm

Copy link

cypress bot commented Nov 14, 2023

Passing run #5636 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0da08d5 into b45b721...
Project: fides Commit: ad64864a4c ℹ️
Status: Passed Duration: 00:35 💡
Started: Dec 13, 2023 5:29 PM Ended: Dec 13, 2023 5:29 PM

Review all test suite changes for PR #4429 ↗︎

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f008dcf) 87.12% compared to head (b17d339) 87.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4429      +/-   ##
==========================================
+ Coverage   87.12%   87.13%   +0.01%     
==========================================
  Files         330      330              
  Lines       20410    20410              
  Branches     2629     2629              
==========================================
+ Hits        17782    17785       +3     
+ Misses       2163     2160       -3     
  Partials      465      465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to notice this user guide link was pointing to square instead of slack-enterprise.

@galvana galvana changed the title Mg con 203 Statsig access and erasure Nov 27, 2023
@galvana galvana self-requested a review November 27, 2023 19:29
@galvana galvana marked this pull request as ready for review November 27, 2023 19:29
@MarcGEthyca
Copy link
Contributor Author

This looks great to me! Do notice I did slip a 'fix' to a doc issue I found while working on this connector. Also, fwiw, I don't think I'm able to be added as a reviewer 😮.

@galvana galvana merged commit 9e98d22 into main Dec 14, 2023
13 of 14 checks passed
@galvana galvana deleted the MG-con-203 branch December 14, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants