-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statsig access and erasure #4429
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5636 ↗︎
Details:
Review all test suite changes for PR #4429 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4429 +/- ##
==========================================
+ Coverage 87.12% 87.13% +0.01%
==========================================
Files 330 330
Lines 20410 20410
Branches 2629 2629
==========================================
+ Hits 17782 17785 +3
+ Misses 2163 2160 -3
Partials 465 465 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happened to notice this user guide link was pointing to square instead of slack-enterprise.
This looks great to me! Do notice I did slip a 'fix' to a doc issue I found while working on this connector. Also, fwiw, I don't think I'm able to be added as a reviewer 😮. |
Closes #CON-203
Description Of Changes
Adding a new erasure connector for Statsig
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/273
https://github.com/ethyca/fidesdocs/issues/271
CHANGELOG.md