Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing request type field #4414

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fixing request type field #4414

merged 4 commits into from
Nov 10, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 10, 2023

Description Of Changes

Request type field enhancements

Code Changes

  • Request type field options are now upper case
  • The field is still shown if there is only one option, but the the field is disabled

Steps to Confirm

  • Create a system
  • Try to add an integration with only one request type (Doordash, Erasure email, Consent email)
  • Verify the request type field still shows up but the field is disabled
  • Verify the options are in upper case (Access, Erasure, Consent)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2023 8:24pm

@cypress Cypress
Copy link

cypress bot commented Nov 10, 2023 •
edited
Loading

Passing run #5192 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5ee4ce6 into e8d934c...
Project: fides Commit: 4b284bfa65 ℹ️
Status: Passed Duration: 00:50 💡
Started: Nov 10, 2023 8:13 PM Ended: Nov 10, 2023 8:14 PM

Review all test suite changes for PR #4414 ↗︎

TheAndrewJackson
TheAndrewJackson approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything is working 👍

@galvana galvana merged commit da09d2a into main Nov 10, 2023
10 of 11 checks passed
@galvana galvana deleted the fix-request-type-field branch November 10, 2023 20:23
galvana added a commit that referenced this pull request Nov 10, 2023
@galvana
Fixing request type field (#4414)
d42008b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @TheAndrewJackson