-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Con 102mg ada chatbot #4382
Con 102mg ada chatbot #4382
Conversation
Passing run #5135 ↗︎
Details:
Review all test suite changes for PR #4382 ↗︎ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4382 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 329 329
Lines 20309 20309
Branches 2610 2610
=======================================
Hits 17687 17687
Misses 2160 2160
Partials 462 462 ☔ View full report in Codecov by Sentry. |
A couple of notes: |
- name: compliance_access_token | ||
sensitive: True | ||
description: The Data Compliance API value. This value can be seen by going to the Settings --> Integrations within the Admin GUI (https://developers.ada.cx/reference/authentication) | ||
label: Data Compliance API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct label for the compliance_access_token
? The description mentions the "The Data Compliance API" but that doesn't seem right to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just needs a quick check on one of the connector params
Closes #
Description Of Changes
Created a new Erasure only Connector for Ada Chatbot
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/255
https://github.com/ethyca/fidesdocs/issues/254
CHANGELOG.md