Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Con 102mg ada chatbot #4382

Merged
merged 30 commits into from
Nov 8, 2023
Merged

Con 102mg ada chatbot #4382

merged 30 commits into from
Nov 8, 2023

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Nov 3, 2023

Closes #

Description Of Changes

Created a new Erasure only Connector for Ada Chatbot

Code Changes

  • Added config, dataset, fixtures and tests to this repo

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

Copy link

cypress bot commented Nov 3, 2023

Passing run #5135 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge fedc2b9 into 4bdbbe5...
Project: fides Commit: ab67dfdb76 ℹ️
Status: Passed Duration: 00:33 💡
Started: Nov 8, 2023 8:50 PM Ended: Nov 8, 2023 8:51 PM

Review all test suite changes for PR #4382 ↗︎

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:00pm

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (317dd15) 87.08% compared to head (04d5f6e) 87.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4382   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         329      329           
  Lines       20309    20309           
  Branches     2610     2610           
=======================================
  Hits        17687    17687           
  Misses       2160     2160           
  Partials      462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca
Copy link
Contributor Author

A couple of notes:
1 - At the moment I can't verify emails are sent from the Fides admin =(
2 - I tried to undo the changes I made to .fides/fides.toml I can see my actual addition is gone but spacing changes due to 'command+s' re-arranged some lines =(. I was able to fix it, right until I saved again =/

@MarcGEthyca MarcGEthyca marked this pull request as ready for review November 7, 2023 20:13
- name: compliance_access_token
sensitive: True
description: The Data Compliance API value. This value can be seen by going to the Settings --> Integrations within the Admin GUI (https://developers.ada.cx/reference/authentication)
label: Data Compliance API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct label for the compliance_access_token? The description mentions the "The Data Compliance API" but that doesn't seem right to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used that name to match what this is called in the Ada chatbot admin interface. I thought it should match what it is called in the spot they hopefully are looking for it?

This is what it looks like
Screenshot 2023-11-08 at 7 49 02 AM

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just needs a quick check on one of the connector params

@galvana galvana merged commit 6440dec into main Nov 8, 2023
14 checks passed
@galvana galvana deleted the CON-102mgAdaChatbot branch November 8, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants