Adding default_value and hidden properties to custom privacy request fields #4370
Conversation
| last_name: { | ||
| label: "Last name", | ||
| value: "", | ||
| }, | ||
| color: { | ||
| label: "Color", | ||
| value: "blue", | ||
| }, | ||
| tenant_id: { | ||
| label: "Tenant ID", | ||
| value: "123", | ||
| }, |
There was a problem hiding this comment.
Verifying a few scenarios with this check
- A non-required field still contains a value, even if it's an empty string
- A field with a
default_valuecan be overwritten in the form - A hidden field with a
default_valueis still included with the entered form values in the request
| if (field.hidden && field.default_value === undefined) { | ||
| return { | ||
| isValid: false, | ||
| message: `Default value required for hidden field '${key}' in action '${action.policy_key}'`, |
There was a problem hiding this comment.
This error message doesn't surface completely, but I see that's a known issue #3171
There was a problem hiding this comment.
this doesn't appear to be working—I set a value to hidden without a default_value but it still says isValid = true!
I think forEach returns don't work quite as we expect them to here: https://stackoverflow.com/questions/56129153/how-to-return-a-value-from-foreach
| <Text fontSize="sm" color="gray.600" mb={4}> | ||
| {action.description} | ||
| </Text> | ||
| <ModalBody maxHeight={400} overflowY="auto"> |
There was a problem hiding this comment.
Updating the popup to scroll if the form body exceeds 400px
Passing run #5060 ↗︎
Details:
Review all test suite changes for PR #4370 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4370 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 328 328
Lines 20267 20267
Branches 2608 2608
=======================================
Hits 17642 17642
Misses 2162 2162
Partials 463 463 ☔ View full report in Codecov by Sentry. |
galvana
force-pushed
the
PROD-1250-add-hidden-fields-to-privacy-requests
branch
from
eec6512 to
f32b016
Compare
| if (field.hidden && field.default_value === undefined) { | ||
| return { | ||
| isValid: false, | ||
| message: `Default value required for hidden field '${key}' in action '${action.policy_key}'`, |
There was a problem hiding this comment.
this doesn't appear to be working—I set a value to hidden without a default_value but it still says isValid = true!
I think forEach returns don't work quite as we expect them to here: https://stackoverflow.com/questions/56129153/how-to-return-a-value-from-foreach
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Description Of Changes
Adding the ability to support hidden custom privacy request fields. This requires the addition of a default value so I added two new properties
default_valueandhidden.I also limited the height of the privacy request form field and added scrolling.
Code Changes
smoke_test.cy.tsSteps to Confirm
nox -s "fides_env(test)"Pre-Merge Checklist
CHANGELOG.md