Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Con 74 mg typeform connector erasure #4366

Merged
merged 35 commits into from
Nov 8, 2023

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented Oct 31, 2023

Closes #CON-74

Description Of Changes

Added Typeform Erasure Connector

Code Changes

  • Added an erasure connector so config, dataset, fixtures, and tests for Typeform

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Create an Access DSR with the identity value
  • [] Verify email sent by Fides with customer data is correct

Pre-Merge Checklist

Pre-PR checklist

  • Secrets added to 1Password
    • Values for connector_params
    • Any identity values, such as identity_email or identity_phone_number
  • Postman collection
    • All requests in the SaaS config
    • [N/A] All requests to create test data
  • Erasure tests passing

Copy link

cypress bot commented Oct 31, 2023

Passing run #5121 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge df81efc into 317dd15...
Project: fides Commit: 83c04766c6 ℹ️
Status: Passed Duration: 00:48 💡
Started: Nov 8, 2023 3:55 AM Ended: Nov 8, 2023 3:56 AM

Review all test suite changes for PR #4366 ↗︎

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (317dd15) 87.08% compared to head (df81efc) 87.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4366   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         329      329           
  Lines       20309    20309           
  Branches     2610     2610           
=======================================
  Hits        17687    17687           
  Misses       2160     2160           
  Partials      462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca
Copy link
Contributor Author

MarcGEthyca commented Nov 2, 2023

We are still seeing some weirdness with the icon for Typeform. While it's in the right place etc... you'll see if you go to create a new integration --> and look for the Typeform connector, you'll see the icon looks as if it's stretched and we can only see the middle of the icon. I've tried several different icons, but I haven't been able to improve on this behaviour so far. Also, while I can create and now approve a DSR -- I have yet to get an email =(

** update**
Adrian pointed out that more setup is needed for that to work, and that for testing we can check the fides upload folder to see if the request gets put there (so far with no luck).

@MarcGEthyca MarcGEthyca marked this pull request as ready for review November 2, 2023 15:26
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 9:02pm

@MarcGEthyca
Copy link
Contributor Author

Notes:
1 - Currenty I am not able to verify emails sent.
2 - I did try to undo the changes I made to src/fides/data/sample_project/fides.toml - but I can't seem to find a way to undo the spacing changes that <command+s> added =/

@galvana galvana merged commit 26ee3e2 into main Nov 8, 2023
@galvana galvana deleted the CON-74-mg-typeform-connector-erasure branch November 8, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants