-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Con 74 mg typeform connector erasure #4366
Conversation
Passing run #5121 ↗︎
Details:
Review all test suite changes for PR #4366 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4366 +/- ##
=======================================
Coverage 87.08% 87.08%
=======================================
Files 329 329
Lines 20309 20309
Branches 2610 2610
=======================================
Hits 17687 17687
Misses 2160 2160
Partials 462 462 ☔ View full report in Codecov by Sentry. |
We are still seeing some weirdness with the icon for Typeform. While it's in the right place etc... you'll see if you go to create a new integration --> and look for the Typeform connector, you'll see the icon looks as if it's stretched and we can only see the middle of the icon. I've tried several different icons, but I haven't been able to improve on this behaviour so far. Also, while I can create and now approve a DSR -- I have yet to get an email =( ** update** |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Notes: |
Closes #CON-74
Description Of Changes
Added Typeform Erasure Connector
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/245
https://github.com/ethyca/fidesdocs/issues/249
CHANGELOG.md
Pre-PR checklist
connector_params
identity_email
oridentity_phone_number