Remove duplicate FidesUpdated event and trigger FidesInitialized twice instead
#4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #4938 ↗︎
Details:
Review all test suite changes for PR #4365 ↗︎ |
||||||||||||||||||||
NevilleS
commented
Oct 31, 2023
clients/fides-js/src/fides-tcf.ts
Outdated
| } | ||
| dispatchFidesEvent("FidesUpdated", cookie, config.options.debug); | ||
| // Dispatch the "FidesInitialized" event to update listeners with the initial state. | ||
| // TODO PROD-1280: Suppress duplicate event if the cookie state is unchanged from an early initialization? |
There was a problem hiding this comment.
I'm really not sure about this yet. I like the simplicity of this code right now, but the double-triggering of the event doesn't "feel" great. Looking for opinions 😄
Comment on lines
1363
to
1364
| // TODO PROD-1280: Suppress duplicate event if the cookie state is unchanged from an early initialization? | ||
| // .should("have.been.calledOnce") |
There was a problem hiding this comment.
Note that we shouldn't check this in; need to decide what to do and then do it 👍
Comment on lines
1412
to
1413
| // TODO PROD-1280: Suppress duplicate event if the cookie state is unchanged from an early initialization? | ||
| // .should("have.been.calledOnce") |
There was a problem hiding this comment.
Note that we shouldn't check this in; need to decide what to do and then do it 👍
clients/fides-js/src/fides.ts
Outdated
| } | ||
| dispatchFidesEvent("FidesUpdated", cookie, config.options.debug); | ||
| // Dispatch the "FidesInitialized" event to update listeners with the initial state. | ||
| // TODO PROD-1280: Suppress duplicate event if the cookie state is unchanged from an early initialization? |
|
We decided to move forward with this implementation for now, but perhaps we should suppress the duplicate |
eastandwestwind
approved these changes
Oct 31, 2023
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
Nov 1, 2023
…twice instead (#4365) Co-authored-by: Allison King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-1280
Description Of Changes
FidesUpdatedis now only called when a user makes a change, not after initialization.Screen.Recording.2023-10-31.at.4.23.37.PM.mov
Code Changes
FidesUpdatedin initialization logicFidesInitializedcallsSteps to Confirm
FidesInitializedfired but noFidesUpdatedfiredFidesUpdateduntil you save your preferencesPre-Merge Checklist
CHANGELOG.md