Add initial state to suggestions #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are very lucky, perhaps this will fix #4288 too 🤞 |
Passing run #4879 ↗︎
Details:
Review all test suite changes for PR #4347 ↗︎ |
||||||||||||||||||||
|
Investigating CI failures which appear to be on |
TheAndrewJackson
approved these changes
Oct 26, 2023
allisonking
commented
Oct 26, 2023
| }).as("updateParty"); | ||
| cy.intercept("POST", `/api/v1/plus/custom-metadata/custom-field/bulk`, { | ||
| body: {}, | ||
| }).as("bulkUpdateCustomField"); |
There was a problem hiding this comment.
this is a test that needed to be updated after the changes in ba7f66b
allisonking
commented
Oct 26, 2023
| ]); | ||
| } | ||
| ); | ||
| cy.wait("@bulkUpdateCustomField").then((interception) => { |
There was a problem hiding this comment.
also a result of the new bulk update endpoint (which is a lot nicer than what we used to have!)
TheAndrewJackson
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-1255
Description Of Changes
This was a very strange bug, and I think it was introduced by #4294 (comment) but even that seems to be a bit of a red herring...
First I found that if I reverted that particular change described in that comment, things worked. I did a diff between
systemBodyandresult.data, then added all the fields until I found the one that was causing things to break which was mysteriouslythird_country_transfers. There's no rhyme or reason to this as far as I can tell, so I dug further...Then I realized the only fields that were being reset were the dictionary fields, so I looked specifically at
useDictSuggestion.It seems like this line https://github.com/ethyca/fides/blob/aking/prod-1255/fix-system-info-saving/clients/admin-ui/src/features/system/dictionary-form/DictSuggestionInputs.tsx/#L88-L92 was causing problems. The
initialValueswere properly set, but that bit of code would reset all those fields to empty strings sovalueswould be incorrect. Again, this only happens whenthird_country_transfersis included, which is very strange, and I suspect is not entirely the root cause and may be a red herring (or a sign of something else).By adding a new suggestion state
initialwe can get around this—that line will only fire when we actually want "presuggestions" which I think works pretty well.Screen.Recording.2023-10-26.at.12.27.21.PM.mov
Code Changes
initialstate to suggestionsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md