Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible legal basis input styling #4346

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Flexible legal basis input styling #4346

merged 6 commits into from
Oct 27, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Oct 26, 2023 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/PROD-1279

Description Of Changes

Before After
image image

Code Changes

  • Font size tweak
  • Padding tweak

Steps to Confirm

  • Visit a system's privacy declarations and observe the new styling

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Oct 26, 2023 •
edited
Loading

Passing run #4881 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 40becf1 into be1eac0...
Project: fides Commit: 1c7e000171 ℹ️
Status: Passed Duration: 01:12 💡
Started: Oct 27, 2023 12:17 PM Ended: Oct 27, 2023 12:18 PM

Review all test suite changes for PR #4346 ↗︎

@allisonking allisonking marked this pull request as ready for review October 26, 2023 15:21
@Kelsey-Ethyca
Copy link
Contributor

UAT ✅
Code review ✅

@allisonking
Copy link
Contributor Author

Failing tests are known and ticketed here: #4288

@allisonking allisonking merged commit 05dfb52 into main Oct 27, 2023
10 of 11 checks passed
@allisonking allisonking deleted the aking/flexible-legal-basis-font-size branch October 27, 2023 13:03
allisonking added a commit that referenced this pull request Oct 27, 2023
@allisonking
Flexible legal basis input styling (#4346)
bf25e07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @Kelsey-Ethyca