Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubspot Connector Update #4322

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Hubspot Connector Update #4322

merged 10 commits into from
Oct 25, 2023

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Oct 23, 2023

Description Of Changes

The Hubspot integration was causing some errors because we're trying to set read-only metadata. Timestamps were originally set as the user.sensor category, which makes them in-scope for deletion/masking per the default erasure policy. This PR changes those values to system.operations, which will ensure that we do not try to mask them.

Code Changes

  • Update Hubspot timestamps to system.operations
  • Add an override for Email in the Contacts update operation (determined not required elsewhere)

Steps to Confirm

  • Tested the following manually:
  • Create a test contact
  • Create an access request and get data for the contact
  • Create an erasure and have it succeed
  • Follow up with access request again and get only subscription data having been updated to opt out of all

Pre-Merge Checklist

These were causing some errors, because we're trying to set read-only metadata when it's set as a user.sensor category
@RobertKeyser RobertKeyser self-assigned this Oct 23, 2023
@cypress
Copy link

cypress bot commented Oct 23, 2023

Passing run #4833 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 51a9d9a into 7ddea8d...
Project: fides Commit: 0fb7192b58 ℹ️
Status: Passed Duration: 01:12 💡
Started: Oct 25, 2023 9:55 PM Ended: Oct 25, 2023 9:56 PM

Review all test suite changes for PR #4322 ↗︎

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (30bfb30) 87.83% compared to head (51a9d9a) 87.79%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
- Coverage   87.83%   87.79%   -0.05%     
==========================================
  Files         334      335       +1     
  Lines       21079    21100      +21     
  Branches     2742     2744       +2     
==========================================
+ Hits        18515    18525      +10     
- Misses       2099     2110      +11     
  Partials      465      465              
Files Coverage Δ
...rride_implementations/hubspot_request_overrides.py 47.61% <47.61%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy SteveDMurphy marked this pull request as ready for review October 24, 2023 23:15
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking this on! Since I'll be out of office for a few days and wanted to avoid the back-and-forth, I went ahead and made the fixes I would have otherwise commented on. I hope you don't mind 😄

@SteveDMurphy SteveDMurphy merged commit c92c31a into main Oct 25, 2023
38 of 40 checks passed
@SteveDMurphy SteveDMurphy deleted the rkeyser/hubspot-patch branch October 25, 2023 22:40
SteveDMurphy added a commit that referenced this pull request Oct 25, 2023
Co-authored-by: SteveDMurphy <[email protected]>
Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants