-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubspot Connector Update #4322
Hubspot Connector Update #4322
Conversation
These were causing some errors, because we're trying to set read-only metadata when it's set as a user.sensor category
Passing run #4833 ↗︎
Details:
Review all test suite changes for PR #4322 ↗︎ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4322 +/- ##
==========================================
- Coverage 87.83% 87.79% -0.05%
==========================================
Files 334 335 +1
Lines 21079 21100 +21
Branches 2742 2744 +2
==========================================
+ Hits 18515 18525 +10
- Misses 2099 2110 +11
Partials 465 465
☔ View full report in Codecov by Sentry. |
Co-authored-by: Adrian Galvan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking this on! Since I'll be out of office for a few days and wanted to avoid the back-and-forth, I went ahead and made the fixes I would have otherwise commented on. I hope you don't mind 😄
src/fides/api/service/saas_request/override_implementations/hubspot_request_overrides.py
Show resolved
Hide resolved
Co-authored-by: SteveDMurphy <[email protected]> Co-authored-by: Adrian Galvan <[email protected]>
Description Of Changes
The Hubspot integration was causing some errors because we're trying to set read-only metadata. Timestamps were originally set as the
user.sensor
category, which makes them in-scope for deletion/masking per the default erasure policy. This PR changes those values tosystem.operations
, which will ensure that we do not try to mask them.Code Changes
system.operations
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md