-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Version Hash Contents #4313
Conversation
…n consent should be resurfaced. Previously we hashed purpose x legal basis and vendor x legal basis to match what could be saved in the string. This largely updates to save three dimensions together vendor x legal basis x purpose New sections are: - Policy version (no change) - Vendor purpose consents - Vendor purpose legitimate interests - gvl vendors disclosed
Passing run #4782 ↗︎
Details:
Review all test suite changes for PR #4313 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4313 +/- ##
==========================================
+ Coverage 87.82% 87.84% +0.01%
==========================================
Files 333 333
Lines 21056 21065 +9
Branches 2739 2742 +3
==========================================
+ Hits 18493 18504 +11
Misses 2096 2096
+ Partials 467 465 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @pattisdr , nice work! mainly just some documentation nits, but i think the functionality here is spot on and it's a clean update to capture the new requirements 👍
# Conflicts: # CHANGELOG.md # src/fides/api/util/tcf/experience_meta.py
…ag is needed for AC vendors to show up in vendor hash.
Closes https://github.com/ethyca/fidesplus/issues/1172
Description Of Changes
Update the contents of the version hash that is used to determine when consent should be resurfaced for TCF. Previously we hashed
purpose x legal basis
andvendor x legal basis
to match what could be saved in the string. This largely updates to save three dimensions togethervendor x legal basis x purpose
and also includes AC vendors and other applicable systems in the hash, as well as determination of whether vendors moved from GVL 2 to GVL 3Code Changes
TCFVersionHash
which is the object built prior to constructing the version hashSteps to Confirm
nox -s dev -- shell
Pre-Merge Checklist
CHANGELOG.md