Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env var to force TCF env in privacy center #4312

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Add env var to force TCF env in privacy center #4312

merged 7 commits into from
Oct 25, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Oct 20, 2023 •
edited
Loading

Closes #4258

Description Of Changes

Context: https://ethyca.atlassian.net/wiki/spaces/EN/pages/2816933901/2023-10-18+Fides-tcf+without+server+side+geolocation

This is the "quick and easy" method. The more work method is poc'd in #4311, but we decided to get this in first (since the poc relies on this work anyway)

Code Changes

  • Add a new environment variable FIDES_PRIVACY_CENTER__IS_FORCED_TCF=true
  • Add a check to handle an empty GVL (which happens if we are using the TCF overlay but got a Notice experience back, so there's no gvl)
  • Fix for test that sometimes fails on slow connections

Steps to Confirm

  • Set up TCF
  • Run FIDES_PRIVACY_CENTER__IS_FORCED_TCF=true turbo dev
  • VPN to an EU region and visit your privacy center /fides-js-demo.html
  • In the past you would have to tack on a ?geolocation=fr-id here in order to get the TCF overlay. But with this new env var, you'll always get the TCF bundle. You should see your TCF overlay as expected. You should also see a network call being made for the privacy experience, since it wasn't pre-fetched
  • VPN to California and visit your privacy center /fides-js-demo.html
  • You'll get an empty TCF overlay

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Oct 20, 2023 •
edited
Loading

Passing run #4804 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge fd5eaac into cf5814b...
Project: fides Commit: bc99e437e9 ℹ️
Status: Passed Duration: 00:54 💡
Started: Oct 25, 2023 12:26 PM Ended: Oct 25, 2023 12:27 PM

Review all test suite changes for PR #4312 ↗︎

@allisonking allisonking marked this pull request as ready for review October 25, 2023 14:26
@allisonking
Copy link
Contributor Author

Failing tests are unrelated to this PR

eastandwestwind
eastandwestwind approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@allisonking
Copy link
Contributor Author

Great! confirmed that tests are passing locally, except for the one we know about

@allisonking allisonking merged commit edbb4f8 into main Oct 25, 2023
@allisonking allisonking deleted the aking/prod-1174/pc-force-tcf-env branch October 25, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@allisonking @eastandwestwind