-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Update TCF Version #4305
Conversation
…instead of "2.0". - While we're here, stop using the TCF Version to say a previously saved preference was outdated. This isn't very relevant here - we'll use a different set of logic to determine if consent needs to be resurfaced for TCF. - Rename method "record_matches_current_version" to "record_is_current"
Passing run #4720 ↗︎
Details:
Review all test suite changes for PR #4305 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4305 +/- ##
=======================================
Coverage 87.76% 87.77%
=======================================
Files 331 331
Lines 20928 20926 -2
Branches 2715 2714 -1
=======================================
Hits 18368 18368
+ Misses 2093 2092 -1
+ Partials 467 466 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me! i'll trust you that there aren't any other broad implications by switching the default here to True
:)
I think this is ok for now! Preferences saved against notices still use the version of the current notice to determine if the preference is outdated. Nothing else has the concept of an "outdated saved preference" - the may change in the future. |
Closes https://github.com/ethyca/fidesplus/issues/1167
Description Of Changes
Update hardcoded TCF Version saved for consent reporting to 2.2.
Code Changes
record_matches_current_version
torecord_is_current
and change it's default value to True instead of False. Other than Privacy Notices which I am comparing the latest version of the notice to the version on the saved preference, everything else, I'll just say is "True"Steps to Confirm
PATCH http://localhost:8080/api/v1/privacy-preferences
curl -X 'GET'
'http://localhost:8080/api/v1/privacy-experience?show_disabled=true&fides_user_device_id=6f8692dc-43f7-4dc5-97bb-4560c73f5503&systems_applicable=false&include_gvl=false&include_meta=false&page=1&size=50'
-H 'accept: application/json'
Pre-Merge Checklist
CHANGELOG.md