-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render new TCF fields in the overlay using the data map #4286
Conversation
Passing run #4698 ↗︎
Details:
Review all test suite changes for PR #4286 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 331 331
Lines 20922 20928 +6
Branches 2714 2715 +1
=======================================
+ Hits 18362 18368 +6
Misses 2093 2093
Partials 467 467
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allisonking backend is looking good from my POV - nice work! i can see now it wasn't quite as straightforward as it seemed when talking it over. just had a small nit on the fixtures, though it's nuanced enough that i wouldn't blame you if you choose to ignore me 👍
and i'd like @pattisdr to also confirm things look good, since i'm still pretty fresh in the overlay generation codepath!
Reviewing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting concerns about differences in retention periods on the same Purpose across Systems or within the same System -
Thanks for all the assistance @pattisdr and @adamsachs ! I think this is ready for review now 👍 |
Thanks Allison, starting review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Allison, especially moving some of this from the GVL into being pulled from the datamap in the backend. Mostly minor cleanup and another test requested!
clients/admin-ui/src/types/api/models/TCFPurposeConsentRecord.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful job 🌞
thanks for the thorough review @pattisdr ! |
Closes #4255
Description Of Changes
Renders the following TCF fields from data from the data map as opposed to querying gvl.json directly:
Not all of these fields were fully passed over from the backend, so there are some backend changes in this PR as well.
Code Changes
TCFVendorRelationships
privacy_policy_url
toTCFVendorRelationships
in the backendTCFVendorRelationships
EmbeddedPurposes
in vendor dataSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md