Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relationship counts to compute total number of vendors #4275

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Use relationship counts to compute total number of vendors #4275

merged 2 commits into from
Oct 13, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Oct 13, 2023 •
edited
Loading

Closes bug @pattisdr found with vendor count over-counting

Description Of Changes

From Dawn:

This sum seems misleading. I only have four vendors, all four are using consent, and one is using both consent and legitimate interests.
image

This fixes that count. Now that vendor relationships and vendor systems have the full list of vendors/systems, we can query off of their lengths directly instead of reconciling their uniqueness.

Code Changes

  • Count based on relationships

Steps to Confirm

  • Add a vendor with both legint and consent purposes
  • It should only show up as 1 vendor in the vendor count

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

pattisdr
pattisdr approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@cypress
Copy link

cypress bot commented Oct 13, 2023 •
edited
Loading

Passing run #4633 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3227534 into 84c0f59...
Project: fides Commit: a1f617c98b ℹ️
Status: Passed Duration: 01:04 💡
Started: Oct 13, 2023 5:14 PM Ended: Oct 13, 2023 5:15 PM

Review all test suite changes for PR #4275 ↗︎

@allisonking
Copy link
Contributor Author

thanks @pattisdr for catching + reviewing! ⭐

@allisonking allisonking marked this pull request as ready for review October 13, 2023 17:56
@allisonking allisonking merged commit 6e5e4a5 into main Oct 13, 2023
10 checks passed
@allisonking allisonking deleted the aking/fix-vendor-count branch October 13, 2023 17:56
adamsachs pushed a commit that referenced this pull request Oct 17, 2023
@allisonking @adamsachs
Use relationship counts to compute total number of vendors (#4275)
c991075
eastandwestwind pushed a commit that referenced this pull request Oct 18, 2023
@allisonking @eastandwestwind
Use relationship counts to compute total number of vendors (#4275)
26368df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattisdr pattisdr pattisdr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @pattisdr