-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass schema updates #4254
Compass schema updates #4254
Conversation
Passing run #4601 ↗︎
Details:
Review all test suite changes for PR #4254 ↗︎ |
…us-1154/compass-schema-update
…mpass-schema-update Conflicts: CHANGELOG.md src/fides/api/models/sql_models.py tests/ctl/core/test_api.py tests/ops/util/test_tcf_experience_contents.py
Tested this branch out with new compass, and generally it is looking good! a few notes on things we can improve (i don't think any of which you could have been aware of!), in order of descending priority from my POV:
on the system model/records:
on the data use/privacy declaration records (this field actually hadn't been populated in airtable, but i just reran generation scripts to re-populate it!):
an example vendor record from compass that can be used for testing is
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration/compass-1.0.0 #4254 +/- ##
==========================================================
Coverage 87.75% 87.75%
==========================================================
Files 331 331
Lines 20906 20906
Branches 2711 2711
==========================================================
Hits 18346 18346
Misses 2093 2093
Partials 467 467 ☔ View full report in Codecov by Sentry. |
…re robust This allows the name field to either be `name`, or fallback to `legal_name`
These files can by regenerated by running: | ||
|
||
``` | ||
turbo run openapi:generate-dictionary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
The dictField
getter is a great idea. Thanks for that refactor!
Closes https://github.com/ethyca/fidesplus/issues/1154
Description Of Changes
The compass endpoint schemas have changed. This updates them so that things still work, particularly:
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md